[OFBiz] Dev - Databaseutil.java

[David E. Jones]

BJ,

Sure, like any other patch that comes in I'll review it and either put 
it in or offer some feedback on it.

It sounds like you have a good idea about how it should work. Thanks 
for your help on this!

-David


On Apr 6, 2005, at 10:35 AM, bjfree at free-man.net wrote:

> Sorry I did not get my idea across,
> You and I are on the same page as far as no specific db code.
> However that is what has happened for repaircolumnsize
> so will you accept a change that makes repaircolumnsize, non DB 
> specific.
> and Yes I had planed to use the helper files, since they need updating
> anyway.
> there are some new minilang that are not covered.
>
>
>
> -----Original Message-----
> From: David E. Jones [mailto:jonesde at ofbiz.org]
> Sent: Wednesday, April 06, 2005 3:41 PM
> To: OFBiz Project Development Discussion (High Traffic)
> Subject: Re: [OFBiz] Dev - Databaseutil.java
>
> BJ,
>
> The current pattern is to NOT have any code that is specific to a
> database.
>
> In other words, there is no "if database is SQLServer then do this else
> do that".
>
> Instead we have configuration options on the datasource element in the
> entityengine.xml file that are used to specify how the Entity Engine
> should behave, and these options are setup for each database. This is
> one of the reasons why we have example configurations for each
> database.
>
> For optimization reasons there are a couple of places in the code that
> need to be changed for something like this, but there are lots of other
> examples you can trace through to see how things fit together.
>
> -David
>
>
> On Apr 6, 2005, at 5:51 AM, bjfree at free-man.net wrote:
>
>> In the SQLprocessor.java there is a way to prepare the statement, so
>> it gets
>> sent the DB in the way it processes calls.
>>
>> In the DatabaseUtil.java the repaircolumnsize is hard coded to use a
>> particular syntax.
>> I would like to re-write this so it takes into account the DB that the
>> command is being sent to.
>>
>> _______________________________________________
>> Dev mailing list
>> Dev at lists.ofbiz.org
>> http://lists.ofbiz.org/mailman/listinfo/dev
>
> _______________________________________________
> Dev mailing list
> Dev at lists.ofbiz.org
> http://lists.ofbiz.org/mailman/listinfo/dev
>
> _______________________________________________
> Dev mailing list
> Dev at lists.ofbiz.org
> http://lists.ofbiz.org/mailman/listinfo/dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2363 bytes
Desc: not available
Url : http://lists.ofbiz.org/pipermail/dev/attachments/20050406/55109393/smime.bin