[OFBiz] SVN: r6940 - trunk/applications/accounting/src/org/ofbiz/accounting/invoice

[David E. Jones]

Not that this is hugely important, but usually with a log call is  
inside an if(verbose) block then it should be a verbose log and not  
an info log. The if block around it is just for performance purposes  
to avoid putting the string together when it won't be used (which is  
somewhat expensive with memory allocations, etc, etc).

-David


On Mar 7, 2006, at 4:30 PM, sichen at svn.ofbiz.org wrote:

> Author: sichen
> Date: 2006-03-07 17:30:28 -0600 (Tue, 07 Mar 2006)
> New Revision: 6940
>
> Modified:
>    trunk/applications/accounting/src/org/ofbiz/accounting/invoice/ 
> InvoiceServices.java
> Log:
> Fixed bug where verbose log message would crash when creating a  
> return invoice.
>
> Modified: trunk/applications/accounting/src/org/ofbiz/accounting/ 
> invoice/InvoiceServices.java
> ===================================================================
> --- trunk/applications/accounting/src/org/ofbiz/accounting/invoice/ 
> InvoiceServices.java	2006-03-07 18:46:04 UTC (rev 6939)
> +++ trunk/applications/accounting/src/org/ofbiz/accounting/invoice/ 
> InvoiceServices.java	2006-03-07 23:30:28 UTC (rev 6940)
> @@ -938,7 +938,7 @@
>                  }
>                  if (Debug.verboseOn()) {
>                      Debug.logInfo("Creating Invoice Item with  
> amount " + returnItem.getBigDecimal("returnPrice") + " and quantity "
> -                            + returnItem.getDouble 
> ("quantityAccepted") + " for shipment receipt [" + receipt.getString 
> ("receiptId") + "]", module);
> +                            + receipt.getBigDecimal 
> ("quantityAccepted") + " for shipment receipt [" + receipt.getString 
> ("receiptId") + "]", module);
>                  }
>
>                  // increment the seqId counter after creating the  
> invoice item and return item billing
>
>
> _______________________________________________
> Svn mailing list
> Svn at lists.ofbiz.org
> http://lists.ofbiz.org/mailman/listinfo/svn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2466 bytes
Desc: not available
Url : http://lists.ofbiz.org/pipermail/svn/attachments/20060307/11cf9025/smime.bin